Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #189, #206, #214, #219 + PPP #234

Merged
merged 15 commits into from
Nov 3, 2020

Conversation

Michaeliaaa
Copy link

@Michaeliaaa Michaeliaaa commented Nov 2, 2020

Fix #189, #206, #214 , #219

@Michaeliaaa Michaeliaaa self-assigned this Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #234 into master will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
- Coverage     62.33%   62.29%   -0.05%     
  Complexity      768      768              
============================================
  Files           120      120              
  Lines          2979     2981       +2     
  Branches        347      348       +1     
============================================
  Hits           1857     1857              
- Misses         1004     1005       +1     
- Partials        118      119       +1     
Impacted Files Coverage Δ Complexity Δ
...ic/commands/appointment/AddAppointmentCommand.java 50.00% <ø> (ø) 8.00 <0.00> (ø)
...c/commands/appointment/EditAppointmentCommand.java 85.71% <ø> (ø) 16.00 <0.00> (ø)
...va/seedu/address/model/history/CommandHistory.java 96.66% <ø> (ø) 16.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 39.28% <ø> (ø) 2.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 89.58% <33.33%> (-1.91%) 34.00 <0.00> (ø)
...address/model/appointment/AppointmentDateTime.java 77.77% <100.00%> (ø) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fbd207...a77a6fb. Read the comment docs.

@Michaeliaaa
Copy link
Author

Do not merge yet. I will need to modify mine after Moon's.

# Conflicts:
#	src/main/java/seedu/address/logic/parser/ParserUtil.java
#	src/main/java/seedu/address/model/appointment/AppointmentDateTime.java
#	src/test/java/seedu/address/logic/parser/ParserUtilTest.java
@Michaeliaaa
Copy link
Author

I realised when I merged Moon's PR to work on the modifications, the format is still following the old one so I updated the format here.

Copy link

@gsmoon97 gsmoon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Michaelia! The pr looks great. There's just one more thing to note about the AppointmentDateTime. Currently, AppointmentDateTime also accepts years beyond 19XX and 2XXX. Also, technically 30 or 31 might not be a valid input for day, depending on the month. So I was thinking you could maybe revert the changes from lines 17 to 21.

@Michaeliaaa
Copy link
Author

Hey Michaelia! The pr looks great. There's just one more thing to note about the AppointmentDateTime. Currently, AppointmentDateTime also accepts years beyond 19XX and 2XXX. Also, technically 30 or 31 might not be a valid input for day, depending on the month. So I was thinking you could maybe revert the changes from lines 17 to 21.

I forgot about it, lemme do amendments to it.

@Michaeliaaa Michaeliaaa changed the title Fix bugs #189, #206, #214, #219 Fix bugs #189, #206, #214, #219 + PPP Nov 3, 2020
@gsmoon97 gsmoon97 merged commit 5fec757 into AY2021S1-CS2103T-W11-4:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] App does not respond when adding appointments with minutes with a positive decimal number
2 participants