Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change implementation of email checking #250

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

ktaekwon000
Copy link
Collaborator

Fixes #215

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #250   +/-   ##
=========================================
  Coverage     61.87%   61.87%           
  Complexity      770      770           
=========================================
  Files           120      120           
  Lines          3019     3019           
  Branches        350      350           
=========================================
  Hits           1868     1868           
  Misses         1032     1032           
  Partials        119      119           
Impacted Files Coverage Δ Complexity Δ
...c/main/java/seedu/address/model/patient/Email.java 86.66% <100.00%> (ø) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9905147...f4dadb6. Read the comment docs.

Copy link

@gsmoon97 gsmoon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice job

@gsmoon97 gsmoon97 merged commit e572c51 into AY2021S1-CS2103T-W11-4:master Nov 6, 2020
@ktaekwon000 ktaekwon000 deleted the email-changes branch November 7, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Invalid Email Address accepted when adding new patient
2 participants