Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling for Tabs & welcome message #252

Merged
merged 4 commits into from
Nov 7, 2020

Conversation

eugene3231
Copy link

java_XP6BR6ENuS

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #252 (be4ed40) into master (e572c51) will increase coverage by 0.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #252      +/-   ##
============================================
+ Coverage     62.30%   63.04%   +0.73%     
  Complexity      777      777              
============================================
  Files           120      119       -1     
  Lines          3019     2982      -37     
  Branches        350      344       -6     
============================================
- Hits           1881     1880       -1     
+ Misses         1016      980      -36     
  Partials        122      122              
Impacted Files Coverage Δ Complexity Δ
...ic/commands/appointment/AddAppointmentCommand.java 66.66% <ø> (ø) 12.00 <0.00> (ø)
...main/java/seedu/address/model/patient/Patient.java 94.02% <ø> (-0.09%) 28.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/VisitFormWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/seedu/address/model/appointment/Appointment.java 92.15% <0.00%> (ø) 23.00% <0.00%> (ø%)
...du/address/model/appointment/UniqueVEventList.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e572c51...be4ed40. Read the comment docs.

Copy link

@gsmoon97 gsmoon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing though. I was thinking maybe it's better to just say "Before you get started, type help to find out how to use CliniCal." or something along those lines. Cause I think it might be bit confusing for some users if the first thing they see are the commands without any description on what they actually do. Other than that, the welcoming message idea looks solid!

@afroneth
Copy link

afroneth commented Nov 6, 2020

Is there a way to partition the tabs so that there is a clearer distinction? I drew a rough sketch below.

Untitled

@Michaeliaaa
Copy link

I agree with Kenneth. I prefer having clearer borders for tabs as well. I think making the unselected tab looked darker in fill would be nicer.

@eugene3231
Copy link
Author

I could only add in some borders for the tab currently selected so like this, however not sure if it looks abit clunky...
And I couldn't find any documentation on how to change the unselected tab styling (making it darker etc)

java_kndwGXNLdd

OR

java_xdKaxOQGyg

@Michaeliaaa
Copy link

For the tab borders, the colours are the same except for the bottom side. It may come across as less appealing to me so I think it is good to make it the same colour. Just a suggestion.

@ktaekwon000 ktaekwon000 merged commit 3d471a6 into AY2021S1-CS2103T-W11-4:master Nov 7, 2020
@eugene3231 eugene3231 added this to the v1.4 milestone Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants