-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styling for Tabs & welcome message #252
Add styling for Tabs & welcome message #252
Conversation
eugene3231
commented
Nov 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
============================================
+ Coverage 62.30% 63.04% +0.73%
Complexity 777 777
============================================
Files 120 119 -1
Lines 3019 2982 -37
Branches 350 344 -6
============================================
- Hits 1881 1880 -1
+ Misses 1016 980 -36
Partials 122 122
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One thing though. I was thinking maybe it's better to just say "Before you get started, type help to find out how to use CliniCal." or something along those lines. Cause I think it might be bit confusing for some users if the first thing they see are the commands without any description on what they actually do. Other than that, the welcoming message idea looks solid!
I agree with Kenneth. I prefer having clearer borders for tabs as well. I think making the unselected tab looked darker in fill would be nicer. |
For the tab borders, the colours are the same except for the bottom side. It may come across as less appealing to me so I think it is good to make it the same colour. Just a suggestion. |