Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile picture #61

Merged

Conversation

afroneth
Copy link

@afroneth afroneth commented Oct 6, 2020

Add profile picture functionality.

For #19

@afroneth afroneth added the enhancement New feature or request label Oct 6, 2020
@afroneth afroneth added this to the v1.2 milestone Oct 6, 2020
@afroneth afroneth self-assigned this Oct 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #61 into master will decrease coverage by 2.76%.
The diff coverage is 42.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
- Coverage     72.18%   69.42%   -2.77%     
- Complexity      410      427      +17     
============================================
  Files            73       77       +4     
  Lines          1251     1380     +129     
  Branches        125      137      +12     
============================================
+ Hits            903      958      +55     
- Misses          313      380      +67     
- Partials         35       42       +7     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/seedu/address/logic/parser/CliniCalParser.java 85.00% <0.00%> (+0.78%) 13.00 <0.00> (+1.00)
.../java/seedu/address/model/util/SampleDataUtil.java 18.75% <0.00%> (-1.25%) 1.00 <0.00> (ø)
...ain/java/seedu/address/storage/StorageManager.java 58.62% <0.00%> (-35.83%) 9.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/PatientCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/ui/PatientListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 57.89% <38.88%> (-17.11%) 4.00 <1.00> (+1.00) ⬇️
...dress/logic/commands/AddProfilePictureCommand.java 41.66% <41.66%> (ø) 3.00 <3.00> (?)
...va/seedu/address/model/patient/ProfilePicture.java 60.00% <60.00%> (ø) 4.00 <4.00> (?)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530ed20...7757056. Read the comment docs.

Copy link
Collaborator

@ktaekwon000 ktaekwon000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a doctor, I can add profile picture to each patient's profile
3 participants