Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds navigation keys to access past commands #67

Merged
merged 5 commits into from Oct 7, 2020

Conversation

Michaeliaaa
Copy link

Allows user to use the up and down button to navigate past commands in the command box and help users to save time from re-typing the command again.

@Michaeliaaa Michaeliaaa self-assigned this Oct 7, 2020
@Michaeliaaa Michaeliaaa added this to the v1.2 milestone Oct 7, 2020
@Michaeliaaa Michaeliaaa added the enhancement New feature or request label Oct 7, 2020
Copy link

@gsmoon97 gsmoon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe you could add some test cases for this functionality later?

@Michaeliaaa
Copy link
Author

Michaeliaaa commented Oct 7, 2020

LGTM! Maybe you could add some test cases for this functionality later?

Yes, definitely. I will try to figure how to test peekNext() and peekPrev().

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5741283). Click here to learn what that means.
The diff coverage is 72.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   69.96%           
  Complexity        ?      442           
=========================================
  Files             ?       77           
  Lines             ?     1405           
  Branches          ?      140           
=========================================
  Hits              ?      983           
  Misses            ?      382           
  Partials          ?       40           
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ui/CommandBox.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/seedu/address/model/history/CommandHistory.java 96.66% <100.00%> (ø) 16.00 <9.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5741283...d043428. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants