Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Patient fields #73

Merged

Conversation

gsmoon97
Copy link

@gsmoon97 gsmoon97 commented Oct 10, 2020

Fixes #10

…into 10-add-new-patient-fields

# Conflicts:
#	src/main/java/seedu/address/logic/commands/AddProfilePictureCommand.java
#	src/main/java/seedu/address/logic/commands/EditCommand.java
#	src/main/java/seedu/address/logic/parser/AddCommandParser.java
#	src/main/java/seedu/address/logic/parser/CliSyntax.java
#	src/main/java/seedu/address/logic/parser/EditCommandParser.java
#	src/main/java/seedu/address/logic/parser/ParserUtil.java
#	src/main/java/seedu/address/model/patient/Patient.java
#	src/main/java/seedu/address/model/util/SampleDataUtil.java
#	src/main/java/seedu/address/storage/JsonAdaptedPatient.java
#	src/test/data/JsonCliniCalStorageTest/invalidAndValidPatientCliniCal.json
#	src/test/data/JsonCliniCalStorageTest/invalidPatientCliniCal.json
#	src/test/data/JsonSerializableCliniCalTest/duplicatePatientCliniCal.json
#	src/test/data/JsonSerializableCliniCalTest/invalidPatientCliniCal.json
#	src/test/data/JsonSerializableCliniCalTest/typicalPatientsCliniCal.json
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/EditCommandParserTest.java
#	src/test/java/seedu/address/storage/JsonAdaptedPatientTest.java
#	src/test/java/seedu/address/testutil/EditPatientDescriptorBuilder.java
#	src/test/java/seedu/address/testutil/PatientBuilder.java
#	src/test/java/seedu/address/testutil/TypicalPatients.java
@gsmoon97 gsmoon97 self-assigned this Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #73 into master will increase coverage by 1.48%.
The diff coverage is 89.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
+ Coverage     71.48%   72.97%   +1.48%     
- Complexity      486      520      +34     
============================================
  Files            81       83       +2     
  Lines          1529     1639     +110     
  Branches        152      172      +20     
============================================
+ Hits           1093     1196     +103     
- Misses          391      393       +2     
- Partials         45       50       +5     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...dress/logic/commands/AddProfilePictureCommand.java 37.03% <0.00%> (-2.97%) 3.00 <0.00> (ø)
...ain/java/seedu/address/model/patient/IcNumber.java 80.00% <ø> (+50.00%) 6.00 <0.00> (+4.00)
src/main/java/seedu/address/ui/PatientCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 17.64% <14.28%> (ø) 1.00 <0.00> (ø)
...main/java/seedu/address/model/allergy/Allergy.java 80.00% <80.00%> (ø) 5.00 <5.00> (?)
...in/java/seedu/address/model/patient/BloodType.java 80.00% <80.00%> (ø) 6.00 <6.00> (?)
src/main/java/seedu/address/model/patient/Sex.java 80.00% <80.00%> (ø) 6.00 <6.00> (?)
...main/java/seedu/address/model/patient/Patient.java 95.31% <96.66%> (+1.43%) 28.00 <6.00> (+5.00)
...java/seedu/address/logic/commands/EditCommand.java 95.95% <100.00%> (+0.89%) 12.00 <0.00> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc1d7f...80ef2bc. Read the comment docs.

@gsmoon97 gsmoon97 changed the title Add new patient fields Add new Patient fields Oct 10, 2020
Copy link

@Michaeliaaa Michaeliaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsmoon97 gsmoon97 merged commit 3a14835 into AY2021S1-CS2103T-W11-4:master Oct 10, 2020
@gsmoon97 gsmoon97 added this to the v1.2 milestone Oct 11, 2020
@gsmoon97 gsmoon97 deleted the 10-add-new-patient-fields branch October 21, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a doctor, I can type/store my patients' data on their individual profile pages
2 participants