-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement for UI #100
Improvement for UI #100
Conversation
EditPatient command now takes in a Name instead of a String
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
============================================
- Coverage 71.62% 70.52% -1.11%
+ Complexity 691 684 -7
============================================
Files 112 110 -2
Lines 2280 2317 +37
Branches 290 296 +6
============================================
+ Hits 1633 1634 +1
- Misses 544 576 +32
- Partials 103 107 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a few nits, LGTM. I think maybe we can separate the changes into multiple PR next time? There seems to be a lot of different changes.
What I did:
Fix the bug where label was not dynamic
Improved the UI a little
Added icons for RoomDetailsPanel
Remove Find Command ( for patients)