Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for UI #100

Merged

Conversation

LeeMingDe
Copy link
Collaborator

@LeeMingDe LeeMingDe commented Oct 19, 2020

What I did:
Fix the bug where label was not dynamic
Improved the UI a little
Added icons for RoomDetailsPanel
Remove Find Command ( for patients)

@LeeMingDe LeeMingDe added Type.BugFix Patches or fixes for a bug Type.Enhancement A small tweak to a feature labels Oct 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #100 into master will decrease coverage by 1.10%.
The diff coverage is 52.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
- Coverage     71.62%   70.52%   -1.11%     
+ Complexity      691      684       -7     
============================================
  Files           112      110       -2     
  Lines          2280     2317      +37     
  Branches        290      296       +6     
============================================
+ Hits           1633     1634       +1     
- Misses          544      576      +32     
- Partials        103      107       +4     
Impacted Files Coverage Δ Complexity Δ
...n/java/seedu/address/commons/core/GuiSettings.java 69.23% <ø> (ø) 5.00 <0.00> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...u/address/logic/commands/room/EditRoomCommand.java 80.00% <0.00%> (-1.16%) 16.00 <0.00> (ø)
...du/address/logic/commands/task/AddTaskCommand.java 52.94% <ø> (ø) 7.00 <0.00> (ø)
...address/logic/commands/task/DeleteTaskCommand.java 37.50% <ø> (ø) 7.00 <0.00> (ø)
...address/logic/commands/task/SearchTaskCommand.java 24.00% <0.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/CovigentAppParser.java 69.23% <0.00%> (-1.14%) 14.00 <0.00> (-1.00)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/main/java/seedu/address/ui/RoomCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/ui/RoomDetailsPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0fe21b...6c185c5. Read the comment docs.

Copy link
Collaborator

@w-yeehong w-yeehong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few nits, LGTM. I think maybe we can separate the changes into multiple PR next time? There seems to be a lot of different changes.

@LeeMingDe LeeMingDe merged commit 6fb5ee2 into AY2021S1-CS2103T-W12-1:master Oct 19, 2020
@w-yeehong w-yeehong linked an issue Oct 21, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type.BugFix Patches or fixes for a bug Type.Enhancement A small tweak to a feature
Projects
None yet
3 participants