Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for editpatientcommand and allocateroomcommand #244

Merged

Conversation

LeeMingDe
Copy link
Collaborator

Fix the optional bug for editpatient as well

@LeeMingDe LeeMingDe added Type.BugFix Patches or fixes for a bug Type.Test More unit tests added labels Nov 7, 2020
@LeeMingDe LeeMingDe added this to the v1.4 milestone Nov 7, 2020
@LeeMingDe LeeMingDe linked an issue Nov 7, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Nov 7, 2020

Codecov Report

Merging #244 (ddf1d1c) into master (c46b747) will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
+ Coverage     68.82%   68.94%   +0.11%     
  Complexity      837      837              
============================================
  Files           120      120              
  Lines          2759     2760       +1     
  Branches        350      350              
============================================
+ Hits           1899     1903       +4     
+ Misses          707      705       -2     
+ Partials        153      152       -1     
Impacted Files Coverage Δ Complexity Δ
...dress/logic/commands/room/AllocateRoomCommand.java 70.76% <0.00%> (ø) 11.00 <0.00> (ø)
...logic/parser/patient/EditPatientCommandParser.java 93.10% <ø> (ø) 9.00 <0.00> (ø)
...s/logic/parser/room/AllocateRoomCommandParser.java 90.47% <ø> (+14.28%) 5.00 <0.00> (+1.00)
src/main/java/seedu/address/model/room/Room.java 90.00% <100.00%> (+0.12%) 28.00 <1.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46b747...ddf1d1c. Read the comment docs.

Copy link
Collaborator

@w-yeehong w-yeehong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few nits, LGTM! Awesome work with adding more test cases. 👍

@LeeMingDe LeeMingDe merged commit d32869b into AY2021S1-CS2103T-W12-1:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type.BugFix Patches or fixes for a bug Type.Test More unit tests added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allocateroom command Optional[]
3 participants