Add noorul json patient edit #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2020 15:42
* 'master' of https://github.com/AY2021S1-CS2103T-W12-1/tp: Add ListRoomCommand and UI for both ListRoom and FindRoomCommand Add ListRoomCommand and UI for both ListRoom and FindRoomCommand Add ListRoomCommand and UI for both ListRoom and FindRoomCommand
… recognised previously but now has to.
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
============================================
+ Coverage 67.07% 67.90% +0.82%
- Complexity 581 636 +55
============================================
Files 102 110 +8
Lines 2017 2203 +186
Branches 236 274 +38
============================================
+ Hits 1353 1496 +143
- Misses 588 617 +29
- Partials 76 90 +14
Continue to review full report at Codecov.
|
added 3 commits
October 12, 2020 20:17
…ed not be recognised previously but now has
…ed not be recognised previously but now has to be Make changes to fix bugs. Pass checkstyle as well.
raymondge
approved these changes
Oct 12, 2020
| return roomNumber == room.roomNumber | ||
| && isOccupied == room.isOccupied | ||
| && taskList.equals(room.getTaskList()); | ||
| if (taskList == null && patient == null) { |
There was a problem hiding this comment.
Nice job to separate to more cases!
| @@ -25,7 +25,9 @@ public void addTask_nullTask_throwsNullPointerException() { | |||
| public void addTask_validTask_success() { | |||
| Room room = new RoomBuilder(ROOM_PATIENT_ALICE_NO_TASK).build(); | |||
| room.addTask(REMIND_PATIENT); | |||
|
|
|||
| System.out.println(room.getTaskList().getInternalList().size()); | |||
There was a problem hiding this comment.
remember to remove the system.out.print after doing the "actual" testing
There was a problem hiding this comment.
Okay, thanks for noticing.
LeeMingDe
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my code for the part to includes reading and saving the Patient details in a class.