Complete SearchRoomCommand #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as long as spellings are the same
…stead of string, class does not interact with roomlist directly
… testing in EditRoomCommandTest), Add EditRoomCommandTest
…into editroomcommandtest * 'master' of https://github.com/AY2021S1-CS2103T-W12-1/tp: Remove redundant code Make changes to according to comments given by reviewers. Make changes to pass checkstyle. Make changes due to problems during merging. Fix checkstyle issues Update to save task list when editing room Update UserGuide.md # Conflicts: # src/main/java/seedu/address/logic/commands/room/EditRoomCommand.java
chiamyunqing
added
Priority.Medium
Type.BugFix
itssodium
requested changes
Oct 14, 2020
src/main/java/seedu/address/logic/commands/room/ListRoomCommand.java
Outdated
Show resolved
Hide resolved
LeeMingDe
approved these changes
Oct 15, 2020
itssodium
approved these changes
Oct 15, 2020
|
|
||
| */ | ||
| return null; | ||
| model.updateFilteredRoomList(room -> room.getRoomNumber() == roomNumber); |
There was a problem hiding this comment.
Maybe can include the predicate in a different method like:
private Predicate getPredicateForSearchRoom(int roomNumberExpected) {
Predicate predicateForSearchRoom = room1 -> room1.getRoomNumber() == roomNumberExpected;
return predicateForSearchRoom;
}
That is wat I meant.
| assertCommandFailure(searchRoomCommand, model, expectedMessage); | ||
| } | ||
|
|
||
| //TODO success test cases once we finalise how rooms UI works |
There was a problem hiding this comment.
Now that it has been finalised, maybe you want to implement it?
There was a problem hiding this comment.
Let's look into resolving the TODOs in v1.3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is quite huge (sorry about that because there's a lot of new PRs being merged this week and I had to keep resolving merge conflicts) so here's a summary of what's done: