Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old classes #178

Merged

Conversation

EthanTheGoondu
Copy link

No description provided.

@EthanTheGoondu EthanTheGoondu added this to the v1.4 milestone Nov 1, 2020
@EthanTheGoondu EthanTheGoondu linked an issue Nov 1, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Nov 1, 2020

Codecov Report

Merging #178 into master will decrease coverage by 4.95%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     43.14%   38.18%   -4.96%     
+ Complexity      540      444      -96     
============================================
  Files           146      136      -10     
  Lines          2777     2496     -281     
  Branches        329      279      -50     
============================================
- Hits           1198      953     -245     
+ Misses         1500     1476      -24     
+ Partials         79       67      -12     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...u/address/logic/commands/AddAttendanceCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eedu/address/logic/commands/AddStudentCommand.java 85.71% <ø> (ø) 8.00 <0.00> (ø)
...address/logic/commands/AttendanceBelowCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ddress/logic/commands/DeleteAttendanceCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...u/address/logic/commands/DeleteStudentCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...dress/logic/commands/EditParticipationCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...edu/address/logic/commands/EditStudentCommand.java 11.59% <ø> (ø) 0.00 <0.00> (ø)
...dress/logic/commands/EditTutorialGroupCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85b65b...14738d7. Read the comment docs.

Copy link

@fanminj fanminj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fanminj fanminj merged commit 5e15647 into AY2021S1-CS2103T-W12-2:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old classes
3 participants