forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch add grp #125
Merged
neoruien
merged 22 commits into
AY2021S1-CS2103T-W12-4:master
from
neoruien:branch-add-grp
Oct 24, 2020
Merged
Branch add grp #125
neoruien
merged 22 commits into
AY2021S1-CS2103T-W12-4:master
from
neoruien:branch-add-grp
Oct 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
neoruien
commented
Oct 22, 2020
- Add Excel XLSX file support
- Change implementation of the code such that XLSX files will be handled instead of CSV files
- Fix addgrp bug (Close addgrp allowing multiple groups with same name #113)
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=============================================
- Coverage 47.61% 35.73% -11.88%
+ Complexity 597 376 -221
=============================================
Files 146 118 -28
Lines 2745 2233 -512
Branches 328 271 -57
=============================================
- Hits 1307 798 -509
- Misses 1360 1361 +1
+ Partials 78 74 -4
Continue to review full report at Codecov.
|
chunyongg
approved these changes
Oct 23, 2020
This reverts commit 4ebb3bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.