Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch add grp #125

Merged
merged 22 commits into from
Oct 24, 2020
Merged

Conversation

neoruien
Copy link
Collaborator

  1. Add Excel XLSX file support
  2. Change implementation of the code such that XLSX files will be handled instead of CSV files
  3. Fix addgrp bug (Close addgrp allowing multiple groups with same name #113)

@neoruien neoruien added this to the v1.3 milestone Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #125 into master will decrease coverage by 11.87%.
The diff coverage is 26.95%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #125       +/-   ##
=============================================
- Coverage     47.61%   35.73%   -11.88%     
+ Complexity      597      376      -221     
=============================================
  Files           146      118       -28     
  Lines          2745     2233      -512     
  Branches        328      271       -57     
=============================================
- Hits           1307      798      -509     
- Misses         1360     1361        +1     
+ Partials         78       74        -4     
Impacted Files Coverage Δ Complexity Δ
src/main/java/team/serenity/Main.java 0.00% <ø> (ø) 0.00 <0.00> (?)
src/main/java/team/serenity/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/team/serenity/commons/core/LogsCenter.java 78.37% <ø> (ø) 10.00 <0.00> (?)
...main/java/team/serenity/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ty/commons/exceptions/DataConversionException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...nity/commons/exceptions/IllegalValueException.java 50.00% <ø> (ø) 1.00 <0.00> (?)
.../main/java/team/serenity/commons/util/AppUtil.java 88.88% <ø> (ø) 5.00 <0.00> (?)
...ava/team/serenity/commons/util/CollectionUtil.java 87.50% <ø> (ø) 5.00 <0.00> (?)
...in/java/team/serenity/commons/util/ConfigUtil.java 75.00% <ø> (ø) 2.00 <0.00> (?)
.../main/java/team/serenity/commons/util/CsvUtil.java 12.24% <0.00%> (ø) 3.00 <0.00> (?)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3bc483...7dbc64d. Read the comment docs.

@neoruien neoruien merged commit 5bb34b9 into AY2021S1-CS2103T-W12-4:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addgrp allowing multiple groups with same name
3 participants