Add more commands and indexing #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/team/serenity/logic/parser/SerenityParser.java
…ipation classes into package
Nijnxw
approved these changes
Oct 26, 2020
…into more_commands # Conflicts: # src/main/java/team/serenity/logic/commands/student/AddStudentCommand.java # src/main/java/team/serenity/logic/commands/student/DelStudentCommand.java # src/main/java/team/serenity/logic/commands/studentinfo/AddScoreCommand.java # src/main/java/team/serenity/logic/commands/studentinfo/MarkAbsentCommand.java # src/main/java/team/serenity/logic/commands/studentinfo/MarkPresentCommand.java # src/main/java/team/serenity/logic/parser/SerenityParser.java # src/main/java/team/serenity/logic/parser/student/DelStudentCommandParser.java # src/main/java/team/serenity/logic/parser/studentinfo/AddScoreCommandParser.java # src/main/java/team/serenity/logic/parser/studentinfo/MarkAbsentCommandParser.java # src/main/java/team/serenity/logic/parser/studentinfo/MarkPresentCommandParser.java # src/main/java/team/serenity/model/ModelManager.java # src/main/java/team/serenity/model/group/studentinfo/Attendance.java # src/test/java/team/serenity/logic/commands/SetScoreCommandTest.java # src/test/java/team/serenity/logic/parser/MarkPresentCommandParserTest.java # src/test/java/team/serenity/model/group/studentinfo/AttendanceTest.java
…into more_commands
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
============================================
- Coverage 46.22% 46.13% -0.09%
- Complexity 600 672 +72
============================================
Files 130 138 +8
Lines 2726 3225 +499
Branches 312 407 +95
============================================
+ Hits 1260 1488 +228
- Misses 1369 1612 +243
- Partials 97 125 +28
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #136
close #156
close #137
Done:
flagattandunflagattcommandmarkpresent,markabsent,delstudent,flagatt,unflagattcommandsid/tomatric/setscorecommand to be split intosetScore,addscore,subscorecommands with indexingComparatorto sort lessons, students and studentsInfo lists