forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch ug peer review update #154
Merged
Nijnxw
merged 18 commits into
AY2021S1-CS2103T-W12-4:master
from
ryanlimjr:branch-ug-peer-review-update
Oct 26, 2020
Merged
Branch ug peer review update #154
Nijnxw
merged 18 commits into
AY2021S1-CS2103T-W12-4:master
from
ryanlimjr:branch-ug-peer-review-update
Oct 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change section 4.1 header from "Setup" to "Setting up" Add missing image for section 3.2.1
…t overview of the key features and a short description about their use
…le inconsistencies in tenses
…or time when it is the name) Rename all instance of LESSON to LESSON_NAME Rename all instances of GROUP to GROUP_NAME for consistency sake
Replace all occurance of e0123456 to A0123456U
… marking attendance section
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
Coverage 46.97% 46.97%
Complexity 561 561
=========================================
Files 125 125
Lines 2559 2559
Branches 300 300
=========================================
Hits 1202 1202
Misses 1259 1259
Partials 98 98 Continue to review full report at Codecov.
|
chunyongg
approved these changes
Oct 26, 2020
…p into branch-ug-peer-review-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues raised are addressed as individual commits
tried adding colours but not reflecting in github but it is reflected in HackMd so not sure if it is working