Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure ButtonBar #195

Merged

Conversation

neoruien
Copy link
Collaborator

@neoruien neoruien commented Oct 29, 2020

  • Refactor ButtonBar such that it extends UiPart instead of VBox
  • Modify QuestionCard text

@neoruien neoruien changed the title Restructure Button Restructure ButtonBar Oct 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #195   +/-   ##
=========================================
  Coverage     48.30%   48.30%           
  Complexity      783      783           
=========================================
  Files           155      155           
  Lines          3857     3857           
  Branches        477      476    -1     
=========================================
  Hits           1863     1863           
  Misses         1850     1850           
  Partials        144      144           
Impacted Files Coverage Δ Complexity Δ
src/main/java/team/serenity/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/team/serenity/ui/SideBar.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/team/serenity/ui/lessondata/QuestionCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e18ad2...8174f4b. Read the comment docs.

@xinyee20 xinyee20 merged commit ee3824c into AY2021S1-CS2103T-W12-4:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants