Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewgrp, viewatt, viewscore, delstudent bugs #196

Merged
merged 5 commits into from
Oct 29, 2020

Conversation

neoruien
Copy link
Collaborator

@neoruien neoruien commented Oct 29, 2020

Fixed parsing and viewing bugs related to the following commands:

  • viewgrp
  • viewatt
  • viewscore
  • delstudent

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #196 into master will increase coverage by 0.11%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
+ Coverage     48.30%   48.41%   +0.11%     
  Complexity      783      783              
============================================
  Files           155      155              
  Lines          3857     3856       -1     
  Branches        477      471       -6     
============================================
+ Hits           1863     1867       +4     
- Misses         1850     1851       +1     
+ Partials        144      138       -6     
Impacted Files Coverage Δ Complexity Δ
...am/serenity/logic/parser/ViewAttCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...am/serenity/logic/parser/ViewGrpCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../serenity/logic/parser/ViewScoreCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../logic/parser/student/DelStudentCommandParser.java 80.76% <100.00%> (+24.10%) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e18ad2...7e5b116. Read the comment docs.

@neoruien neoruien changed the title Fix viewgrp, vieadd, viewscore bugs Fix viewgrp, vieadd, viewscore, delstudent bugs Oct 29, 2020
@neoruien neoruien changed the title Fix viewgrp, vieadd, viewscore, delstudent bugs Fix viewgrp, viewadd, viewscore, delstudent bugs Oct 29, 2020
@neoruien neoruien changed the title Fix viewgrp, viewadd, viewscore, delstudent bugs Fix viewgrp, viewatt, viewscore, delstudent bugs Oct 29, 2020
@xinyee20 xinyee20 merged commit 7595cc6 into AY2021S1-CS2103T-W12-4:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants