Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test case and fix bug #280

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

xinyee20
Copy link
Collaborator

@xinyee20 xinyee20 commented Nov 3, 2020

Update lesson when student info changes
Add testcase for flagatt command

@codecov-io
Copy link

Codecov Report

Merging #280 into master will increase coverage by 2.01%.
The diff coverage is 66.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
+ Coverage     49.75%   51.76%   +2.01%     
- Complexity      804      855      +51     
============================================
  Files           155      155              
  Lines          3871     3931      +60     
  Branches        460      471      +11     
============================================
+ Hits           1926     2035     +109     
+ Misses         1805     1750      -55     
- Partials        140      146       +6     
Impacted Files Coverage Δ Complexity Δ
...main/java/team/serenity/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/team/serenity/logic/commands/ViewAttCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../team/serenity/logic/commands/ViewFlagCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/team/serenity/logic/commands/ViewGrpCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...team/serenity/logic/commands/ViewScoreCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...erenity/logic/commands/question/ViewQnCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...nity/logic/commands/student/DelStudentCommand.java 85.10% <0.00%> (ø) 13.00 <0.00> (ø)
...ty/logic/commands/studentinfo/AddScoreCommand.java 23.94% <0.00%> (-0.70%) 4.00 <0.00> (ø)
...logic/commands/studentinfo/MarkPresentCommand.java 93.24% <ø> (-0.18%) 22.00 <0.00> (ø)
...ty/logic/commands/studentinfo/SetScoreCommand.java 25.75% <0.00%> (-0.81%) 4.00 <0.00> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b6158...43f6942. Read the comment docs.

@chunyongg chunyongg added this to the v1.4 milestone Nov 3, 2020
@chunyongg chunyongg merged commit 1a42baa into AY2021S1-CS2103T-W12-4:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants