Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch addlsn command test #287

Merged

Conversation

ryanlimjr
Copy link
Collaborator

Did test cases for addlsn command

@ryanlimjr ryanlimjr added this to the v1.4 milestone Nov 5, 2020
@ryanlimjr ryanlimjr self-assigned this Nov 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #287 into master will increase coverage by 1.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #287      +/-   ##
============================================
+ Coverage     50.82%   52.34%   +1.51%     
- Complexity      842      866      +24     
============================================
  Files           155      154       -1     
  Lines          3921     3951      +30     
  Branches        471      475       +4     
============================================
+ Hits           1993     2068      +75     
+ Misses         1782     1732      -50     
- Partials        146      151       +5     
Impacted Files Coverage Δ Complexity Δ
.../serenity/logic/commands/lesson/AddLsnCommand.java 92.30% <100.00%> (+68.30%) 8.00 <1.00> (+5.00)
...team/serenity/logic/parser/SerenityParserUtil.java 83.72% <0.00%> (-4.09%) 12.00% <0.00%> (ø%)
...ty/logic/commands/studentinfo/SetScoreCommand.java 25.75% <0.00%> (-0.81%) 4.00% <0.00%> (ø%)
...y/logic/commands/studentinfo/UnflagAttCommand.java 22.41% <0.00%> (-0.81%) 4.00% <0.00%> (ø%)
...ty/logic/commands/studentinfo/AddScoreCommand.java 23.94% <0.00%> (-0.70%) 4.00% <0.00%> (ø%)
...ty/logic/commands/studentinfo/SubScoreCommand.java 23.94% <0.00%> (-0.70%) 4.00% <0.00%> (ø%)
...main/java/team/serenity/commons/util/XlsxUtil.java 42.00% <0.00%> (-0.36%) 20.00% <0.00%> (+3.00%) ⬇️
src/main/java/team/serenity/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/team/serenity/model/group/Group.java 32.14% <0.00%> (ø) 13.00% <0.00%> (ø%)
src/main/java/team/serenity/ui/DataPanel.java
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00f112...44ce415. Read the comment docs.

@Nijnxw Nijnxw merged commit bf74973 into AY2021S1-CS2103T-W12-4:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants