-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More test cases and fix indexing bugs and update lessons #291
More test cases and fix indexing bugs and update lessons #291
Conversation
Add test case, fix update lesson bug, fix indexing bug for unflagatt command
…ommand Add test cases, fix indexing issues, update lesson for setscore command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code quality for the student info commands looks better!!
Test cases are well-written too, just some small tips to make your test cases better :)
src/test/java/team/serenity/logic/commands/studentinfo/UnflagAttCommandTest.java
Outdated
Show resolved
Hide resolved
src/test/java/team/serenity/logic/commands/studentinfo/UnflagAttCommandTest.java
Outdated
Show resolved
Hide resolved
src/test/java/team/serenity/logic/commands/studentinfo/SubScoreCommandTest.java
Show resolved
Hide resolved
src/test/java/team/serenity/logic/commands/studentinfo/SubScoreCommandTest.java
Show resolved
Hide resolved
src/test/java/team/serenity/logic/commands/studentinfo/AddScoreCommandTest.java
Outdated
Show resolved
Hide resolved
src/test/java/team/serenity/logic/commands/studentinfo/AddScoreCommandTest.java
Outdated
Show resolved
Hide resolved
src/test/java/team/serenity/logic/commands/studentinfo/AddScoreCommandTest.java
Outdated
Show resolved
Hide resolved
…into More_Test_Cases # Conflicts: # src/main/java/team/serenity/logic/commands/studentinfo/AddScoreCommand.java # src/test/java/team/serenity/logic/commands/CommandTestUtil.java # src/test/java/team/serenity/logic/commands/studentinfo/FlagAttCommandTest.java # src/test/java/team/serenity/logic/commands/studentinfo/MarkAbsentCommandTest.java # src/test/java/team/serenity/logic/commands/studentinfo/MarkPresentCommandTest.java # src/test/java/team/serenity/logic/parser/studentinfo/AddScoreCommandParserTest.java # src/test/java/team/serenity/logic/parser/studentinfo/FlagAttCommandParserTest.java # src/test/java/team/serenity/logic/parser/studentinfo/MarkAbsentCommandParserTest.java # src/test/java/team/serenity/logic/parser/studentinfo/MarkPresentCommandParserTest.java # src/test/java/team/serenity/logic/parser/studentinfo/SetScoreCommandParserTest.java # src/test/java/team/serenity/logic/parser/studentinfo/SubScoreCommandParserTest.java # src/test/java/team/serenity/logic/parser/studentinfo/UnflagAttCommandParserTest.java # src/test/java/team/serenity/testutil/StudentBuilder.java
…into More_Test_Cases # Conflicts: # src/main/java/team/serenity/logic/parser/studentinfo/AddScoreCommandParser.java # src/main/java/team/serenity/logic/parser/studentinfo/EditScoreCommandParser.java # src/main/java/team/serenity/logic/parser/studentinfo/SubScoreCommandParser.java # src/test/java/team/serenity/logic/commands/studentinfo/EditScoreCommandTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for markpresent, markabsent, flagatt, unflagatt, setscore, addscore, subscore command
close #215