Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link applicant to ui, enable panel change to persist after app closure. #132

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

Ben-Hanan
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #132 into master will decrease coverage by 0.36%.
The diff coverage is 2.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
- Coverage     33.34%   32.97%   -0.37%     
  Complexity      441      441              
============================================
  Files           141      142       +1     
  Lines          3122     3163      +41     
  Branches        378      383       +5     
============================================
+ Hits           1041     1043       +2     
- Misses         2020     2059      +39     
  Partials         61       61              
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/eva/logic/LogicManager.java 27.58% <ø> (ø) 3.00 <0.00> (ø)
.../main/java/com/eva/logic/commands/ViewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/com/eva/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/com/eva/model/ModelManager.java 38.23% <ø> (ø) 24.00 <0.00> (ø)
...a/com/eva/model/current/view/CurrentViewStaff.java 19.23% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/com/eva/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...file/applicant/view/ApplicantBasicInfoDisplay.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../profile/applicant/view/ApplicantProfilePanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...profile/applicant/view/ApplicationInfoDisplay.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/ui/profile/staff/view/StaffBasicInfoDisplay.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c45eb...ccc8900. Read the comment docs.

@Ben-Hanan Ben-Hanan added this to the v1.3 milestone Oct 27, 2020
@TheSpaceCuber
Copy link

LGTM

@Nikhilalalalala Nikhilalalalala merged commit 08fdfe1 into AY2021S1-CS2103T-W13-1:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants