Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine leave #70

Merged
merged 7 commits into from
Oct 20, 2020
Merged

Conversation

Ben-Hanan
Copy link

No description provided.

@Ben-Hanan Ben-Hanan added this to the v1.3 milestone Oct 19, 2020
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #70 into master will decrease coverage by 5.00%.
The diff coverage is 3.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     52.94%   47.93%   -5.01%     
- Complexity      443      448       +5     
============================================
  Files            99      103       +4     
  Lines          1936     2155     +219     
  Branches        205      237      +32     
============================================
+ Hits           1025     1033       +8     
- Misses          872     1083     +211     
  Partials         39       39              
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/eva/commons/util/DateUtil.java 25.00% <0.00%> (+25.00%) 3.00 <0.00> (+3.00)
src/main/java/com/eva/commons/util/StringUtil.java 90.00% <0.00%> (-4.74%) 7.00 <0.00> (ø)
...n/java/com/eva/logic/commands/AddLeaveCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/com/eva/logic/commands/DeleteLeaveCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/com/eva/logic/parser/CliSyntax.java 87.50% <ø> (-3.41%) 1.00 <0.00> (ø)
src/main/java/com/eva/logic/parser/ParserUtil.java 51.35% <0.00%> (-8.97%) 15.00 <0.00> (ø)
...com/eva/logic/parser/comment/CommentCliSyntax.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...eva/logic/parser/comment/CommentCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../eva/logic/parser/comment/DeleteCommandParser.java 100.00% <ø> (ø) 2.00 <0.00> (?)
.../eva/logic/parser/leave/AddLeaveCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea418e...36eaa3b. Read the comment docs.

@Nikhilalalalala
Copy link

Looked through the files changed, I think all looks good and like you mentioned, since leave also heavily uses dates we can change the prefixes to a generalised date prefix.

@IsaacTin
Copy link

lgtm

@IsaacTin IsaacTin merged commit 251498d into AY2021S1-CS2103T-W13-1:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants