forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix being able to add overlapping leaves #89
Merged
TheSpaceCuber
merged 5 commits into
AY2021S1-CS2103T-W13-1:master
from
Ben-Hanan:refine-leave
Oct 24, 2020
Merged
fix being able to add overlapping leaves #89
TheSpaceCuber
merged 5 commits into
AY2021S1-CS2103T-W13-1:master
from
Ben-Hanan:refine-leave
Oct 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
============================================
- Coverage 46.69% 46.49% -0.20%
Complexity 476 476
============================================
Files 109 109
Lines 2388 2398 +10
Branches 280 283 +3
============================================
Hits 1115 1115
- Misses 1220 1230 +10
Partials 53 53
Continue to review full report at Codecov.
|
LGTM! Just some minor comments on the javadocs part. Nice observation on this bug :) |
Ben-Hanan
force-pushed
the
refine-leave
branch
from
October 24, 2020 12:27
55d0fc6
to
5e14dc8
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in being able to add leaves with overlapping periods.
e.g addleave l/d:08/10/2020 d:10/10/2020 l/d:09/10/2020
The above command would not have resulted in an error and added the two leaves as different records of leave but it errors now.
Also made the UI automatically update with any change to leave.