Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix being able to add overlapping leaves #89

Merged
merged 5 commits into from
Oct 24, 2020

Conversation

Ben-Hanan
Copy link

@Ben-Hanan Ben-Hanan commented Oct 20, 2020

Fixed a bug in being able to add leaves with overlapping periods.
e.g addleave l/d:08/10/2020 d:10/10/2020 l/d:09/10/2020
The above command would not have resulted in an error and added the two leaves as different records of leave but it errors now.

Also made the UI automatically update with any change to leave.

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #89 into master will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     46.69%   46.49%   -0.20%     
  Complexity      476      476              
============================================
  Files           109      109              
  Lines          2388     2398      +10     
  Branches        280      283       +3     
============================================
  Hits           1115     1115              
- Misses         1220     1230      +10     
  Partials         53       53              
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/eva/commons/util/DateUtil.java 21.73% <0.00%> (-3.27%) 3.00 <0.00> (ø)
...n/java/com/eva/logic/commands/AddLeaveCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/com/eva/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/com/eva/model/ModelManager.java 45.29% <0.00%> (-2.45%) 25.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2a150...d5550df. Read the comment docs.

@Ben-Hanan Ben-Hanan added this to the v1.3 milestone Oct 20, 2020
@Nikhilalalalala
Copy link

LGTM! Just some minor comments on the javadocs part. Nice observation on this bug :)

@TheSpaceCuber
Copy link

LGTM

@TheSpaceCuber TheSpaceCuber merged commit a4e099d into AY2021S1-CS2103T-W13-1:master Oct 24, 2020
@Nikhilalalalala Nikhilalalalala linked an issue Oct 24, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix being able to add overlapping leaves
4 participants