-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find service functionality #105
Find service functionality #105
Conversation
findsvc command only searches for matching keywords from a Service's title and service code.
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
============================================
- Coverage 43.52% 42.47% -1.05%
Complexity 430 430
============================================
Files 121 126 +5
Lines 2231 2286 +55
Branches 264 275 +11
============================================
Hits 971 971
- Misses 1225 1280 +55
Partials 35 35
Continue to review full report at Codecov.
|
|
||
String[] nameKeywords = trimmedArgs.split("\\s+"); | ||
|
||
return new FindServiceCommand(new ServiceContainKeywordPredicate(Arrays.asList(nameKeywords))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we can follow the original client find command, because for that command, we don't have to parse the different prefixes. Whereas for findsvc, we need to parse for both title and service code and ensure that only one of them is chosen. Can see @yanlynnnnn 's findexp command to see how she did hers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thanks! I'll change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.