Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find service functionality #105

Merged

Conversation

hanstirtaputra
Copy link

No description provided.

@hanstirtaputra hanstirtaputra added this to the v1.2 milestone Oct 10, 2020
@hanstirtaputra hanstirtaputra self-assigned this Oct 10, 2020
@hanstirtaputra hanstirtaputra linked an issue Oct 10, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #105 into master will decrease coverage by 1.04%.
The diff coverage is 1.40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
- Coverage     43.52%   42.47%   -1.05%     
  Complexity      430      430              
============================================
  Files           121      126       +5     
  Lines          2231     2286      +55     
  Branches        264      275      +11     
============================================
  Hits            971      971              
- Misses         1225     1280      +55     
  Partials         35       35              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ess/logic/commands/expense/FindExpenseCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ress/logic/commands/service/AddServiceCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ess/logic/commands/service/EditServiceCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ess/logic/commands/service/FindServiceCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 55.17% <0.00%> (-1.98%) 12.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 42.25% <0.00%> (-3.21%) 12.00 <0.00> (ø)
...logic/parser/service/FindServiceCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...main/java/seedu/address/model/service/Service.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93c59e...f8ae5e9. Read the comment docs.


String[] nameKeywords = trimmedArgs.split("\\s+");

return new FindServiceCommand(new ServiceContainKeywordPredicate(Arrays.asList(nameKeywords)));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we can follow the original client find command, because for that command, we don't have to parse the different prefixes. Whereas for findsvc, we need to parse for both title and service code and ensure that only one of them is chosen. Can see @yanlynnnnn 's findexp command to see how she did hers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks! I'll change it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

Copy link

@RuiFengg RuiFengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RuiFengg RuiFengg merged commit 04c0fd0 into AY2021S1-CS2103T-W13-3:master Oct 12, 2020
@hanstirtaputra hanstirtaputra linked an issue Oct 12, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change findsvc command to take in prefixes As a home-based beauty salon owner, I want to find a service
4 participants