Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for client #207

Merged

Conversation

RuiFengg
Copy link

Added more tests for logic and model for client

@RuiFengg RuiFengg self-assigned this Oct 26, 2020
@RuiFengg RuiFengg added priority.High Must do type:Testing Any improvement to test coverage of the project. labels Oct 26, 2020
@RuiFengg RuiFengg added this to the v1.3 milestone Oct 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #207 into master will increase coverage by 6.13%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #207      +/-   ##
============================================
+ Coverage     34.77%   40.90%   +6.13%     
- Complexity      594      734     +140     
============================================
  Files           201      205       +4     
  Lines          3825     3850      +25     
  Branches        443      442       -1     
============================================
+ Hits           1330     1575     +245     
+ Misses         2434     2192     -242     
- Partials         61       83      +22     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/homerce/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/seedu/homerce/model/client/UniqueClientList.java 90.74% <ø> (+12.96%) 26.00 <0.00> (+4.00)
...ava/seedu/homerce/model/manager/ClientManager.java 81.25% <0.00%> (ø) 13.00 <0.00> (ø)
...e/logic/parser/client/FindClientCommandParser.java 100.00% <100.00%> (+73.68%) 9.00 <0.00> (+6.00)
...va/seedu/homerce/model/manager/RevenueTracker.java 48.57% <0.00%> (-4.56%) 6.00% <0.00%> (ø%)
...java/seedu/homerce/logic/parser/HomerceParser.java 31.91% <0.00%> (-0.70%) 11.00% <0.00%> (ø%)
...rce/logic/commands/revenue/ListRevenueCommand.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...seedu/homerce/model/revenue/RevenueComparator.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...logic/parser/revenue/SortRevenueCommandParser.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...omerce/model/revenue/RevenueDefaultComparator.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87ee87...6cf0b86. Read the comment docs.

Copy link

@yanlynnnnn yanlynnnnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yanlynnnnn yanlynnnnn merged commit 23b22ab into AY2021S1-CS2103T-W13-3:master Oct 26, 2020
Copy link

@hanstirtaputra hanstirtaputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type:Testing Any improvement to test coverage of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants