Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for expense (storage, parser) #212

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

yanlynnnnn
Copy link

Add tests for expense (storage, parser)

@yanlynnnnn yanlynnnnn added priority.High Must do type:Testing Any improvement to test coverage of the project. labels Oct 26, 2020
@yanlynnnnn yanlynnnnn added this to the v1.3 milestone Oct 26, 2020
@yanlynnnnn yanlynnnnn self-assigned this Oct 26, 2020
@yanlynnnnn yanlynnnnn linked an issue Oct 26, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #212 into master will increase coverage by 5.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     45.63%   50.98%   +5.35%     
- Complexity      816      895      +79     
============================================
  Files           205      205              
  Lines          3850     3852       +2     
  Branches        442      443       +1     
============================================
+ Hits           1757     1964     +207     
+ Misses         1991     1773     -218     
- Partials        102      115      +13     
Impacted Files Coverage Δ Complexity Δ
...erce/logic/commands/expense/AddExpenseCommand.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...e/logic/commands/expense/DeleteExpenseCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...rce/logic/commands/expense/EditExpenseCommand.java 76.47% <ø> (+4.41%) 8.00 <0.00> (ø)
...rce/logic/commands/expense/FindExpenseCommand.java 100.00% <ø> (+100.00%) 7.00 <0.00> (+7.00)
...rce/logic/commands/expense/SortExpenseCommand.java 100.00% <ø> (+100.00%) 2.00 <0.00> (+2.00)
...torage/expense/JsonSerializableExpenseTracker.java 71.05% <ø> (+60.52%) 8.00 <0.00> (+7.00)
...du/homerce/storage/expense/JsonAdaptedExpense.java 76.92% <100.00%> (+76.92%) 12.00 <2.00> (+12.00)
...main/java/seedu/homerce/model/expense/Expense.java 85.29% <0.00%> (-2.95%) 11.00% <0.00%> (-1.00%)
...va/seedu/homerce/model/manager/ExpenseTracker.java 78.94% <0.00%> (+15.78%) 13.00% <0.00%> (+4.00%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff20be...caf3192. Read the comment docs.

@khoongwk khoongwk self-requested a review October 27, 2020 09:01
Copy link

@khoongwk khoongwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khoongwk khoongwk merged commit 3c94b2f into AY2021S1-CS2103T-W13-3:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type:Testing Any improvement to test coverage of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for Expense storage and parser
3 participants