Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Appointment (Model) #217

Merged

Conversation

khoongwk
Copy link

No description provided.

@khoongwk khoongwk added priority.Medium Nice to have type:Testing Any improvement to test coverage of the project. labels Oct 27, 2020
@khoongwk khoongwk added this to the v1.3 milestone Oct 27, 2020
@khoongwk khoongwk self-assigned this Oct 27, 2020
@khoongwk khoongwk linked an issue Oct 27, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #217 into master will increase coverage by 3.92%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
+ Coverage     50.98%   54.91%   +3.92%     
- Complexity      895      977      +82     
============================================
  Files           205      204       -1     
  Lines          3852     3848       -4     
  Branches        443      445       +2     
============================================
+ Hits           1964     2113     +149     
+ Misses         1773     1610     -163     
- Partials        115      125      +10     
Impacted Files Coverage Δ Complexity Δ
...rce/logic/commands/schedule/CustomWeekCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/homerce/model/ModelManager.java 56.45% <0.00%> (+0.60%) 39.00 <0.00> (ø)
...ava/seedu/homerce/model/appointment/TimeOfDay.java 94.11% <ø> (+10.78%) 10.00 <0.00> (+2.00)
...eedu/homerce/model/manager/AppointmentManager.java 74.50% <0.00%> (+23.56%) 12.00 <0.00> (+5.00)
...eedu/homerce/ui/schedulepanel/AppointmentSlot.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ppointment/predicate/AppointmentWeekPredicate.java 89.28% <75.00%> (ø) 14.00 <5.00> (?)
...a/seedu/homerce/model/appointment/Appointment.java 89.70% <100.00%> (+86.76%) 24.00 <0.00> (+22.00)
...java/seedu/homerce/model/util/attributes/Date.java 85.00% <0.00%> (+5.00%) 11.00% <0.00%> (+1.00%)
...eedu/homerce/model/util/uniquelist/UniqueList.java 91.66% <0.00%> (+10.41%) 24.00% <0.00%> (+5.00%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c94b2f...9d5c7fa. Read the comment docs.

Copy link

@yanlynnnnn yanlynnnnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETM

@yanlynnnnn yanlynnnnn merged commit 779b7ed into AY2021S1-CS2103T-W13-3:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type:Testing Any improvement to test coverage of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Tests for Appointment (Model)
3 participants