Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units Tests for Appointment (Logic and Storage) #236

Conversation

khoongwk
Copy link

Apart from unit tests, some minor changes: modified ModelManager's equals method to compare the other managers and trackers apart from just client manager.

@khoongwk khoongwk added priority.Medium Nice to have type:Testing Any improvement to test coverage of the project. labels Oct 30, 2020
@khoongwk khoongwk added this to the v1.4 milestone Oct 30, 2020
@khoongwk khoongwk self-assigned this Oct 30, 2020
@khoongwk khoongwk linked an issue Oct 30, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #236 into master will increase coverage by 9.01%.
The diff coverage is 47.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #236      +/-   ##
============================================
+ Coverage     54.33%   63.34%   +9.01%     
- Complexity      977     1113     +136     
============================================
  Files           206      206              
  Lines          3889     3915      +26     
  Branches        452      462      +10     
============================================
+ Hits           2113     2480     +367     
+ Misses         1651     1274     -377     
- Partials        125      161      +36     
Impacted Files Coverage Δ Complexity Δ
...commands/appointment/DeleteAppointmentCommand.java 100.00% <ø> (+100.00%) 7.00 <0.00> (+7.00)
...c/commands/appointment/DoneAppointmentCommand.java 90.90% <ø> (+90.90%) 7.00 <0.00> (+7.00)
...c/commands/appointment/ListAppointmentCommand.java 100.00% <ø> (+100.00%) 2.00 <0.00> (+2.00)
...commands/appointment/UnDoneAppointmentCommand.java 83.33% <ø> (+83.33%) 7.00 <0.00> (+7.00)
...rser/appointment/FindAppointmentCommandParser.java 96.42% <ø> (+96.42%) 14.00 <0.00> (+14.00)
...rc/main/java/seedu/homerce/model/ModelManager.java 71.95% <0.00%> (+15.50%) 52.00 <0.00> (+13.00)
...a/seedu/homerce/model/appointment/Appointment.java 91.17% <ø> (+1.47%) 25.00 <0.00> (+1.00)
...edu/homerce/model/appointment/AppointmentTemp.java 65.00% <22.22%> (-35.00%) 7.00 <2.00> (+2.00) ⬇️
...c/commands/appointment/FindAppointmentCommand.java 100.00% <100.00%> (+100.00%) 7.00 <1.00> (+7.00)
.../java/seedu/homerce/model/service/ServiceCode.java 85.71% <100.00%> (-0.96%) 10.00 <1.00> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83e1f1...1c659e1. Read the comment docs.

Copy link

@hanstirtaputra hanstirtaputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanstirtaputra hanstirtaputra merged commit bb675dd into AY2021S1-CS2103T-W13-3:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type:Testing Any improvement to test coverage of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tests for Appointment (Logic, Storage)
3 participants