Add shared misc classes for refactor #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuiFengg
requested review from
galvinleow,
hanstirtaputra,
khoongwk and
yanlynnnnn
RuiFengg
added
priority.High
RuiFengg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created skeleton classes and packages for refactor. Fleshed out basic functionality for shared misc classes.
Added packages appointment, revenue, expense, service in model package with skeleton classes.
Added common class attributes Date, Amount(changed money to amount as it sounds more apt), Description into model/util/attributes package
We could consider creating an abstract class finance for expense and revenue since they both have money and date that can be abstracted out
Tests for misc classes not added yet.