-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG - Overall Structure, Product Scope, NFR #73
Update DG - Overall Structure, Product Scope, NFR #73
Conversation
* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp: Revert "Add Skeleton (2)" Add Skeleton (2) Add Task Package Add Table of Contents to DG Edit DG Non-functional Requirements Update UG (Preset Tasks and Modules)
* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp: Update personal page Edit config Add skeleton format for DG to fit new target user Update skeletal user guide Update DG use case to match with updated UG Update UG Update UG based on PR Review Update UG to fix scope change Update UG command summary Update UG with fix naming convention Update DG use case with standardised terms used across UG Add use cases for developer guide v1.1
* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp: Update README Fix Checkstyle Add User Stories Fix checkstyle errors Create amount class Create date class Create description class Set up skeleton framework Update UG based on comments Update ReadMe Update command summary Revert "Merge branch 'user_guide_v1.1' into upstream_master" Update UG to add example - Basic code for FixedDay, Duration and TaskName - Addition of Enum Class - Update methods in ParserUtil for FixedDay, Duration and TaskName
* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp: Replace person instance with client Fix testcases Edit UG for expenses Change formatting of UG Add documentation for expense feature in User Guide, and update individual portfolios to new theme Fix checkstyle errors Add attribute for ServiceCode Add tests for description Add tests for date class Add test for amount class Remove address field
The current DG's document structure could be more organised. Let's add a table of contents and number each section accordingly.
Minor edits to NFR and Product Scope section to suit the new scope of GrAB3.
No newline was found at the end of the DG file. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make all fullstops for DG to standardize
Adding of full stops to all bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Improvement to overall structure of DG to include table of contents and section numbering.
Minor edits to product scope and non-functional requirements to suit the new project direction.