Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG - Overall Structure, Product Scope, NFR #73

Merged

Conversation

khoongwk
Copy link

@khoongwk khoongwk commented Oct 3, 2020

Improvement to overall structure of DG to include table of contents and section numbering.

Minor edits to product scope and non-functional requirements to suit the new project direction.

* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp:
  Revert "Add Skeleton (2)"
  Add Skeleton (2)
  Add Task Package
  Add Table of Contents to DG
  Edit DG Non-functional Requirements
  Update UG (Preset Tasks and Modules)
* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp:
  Update personal page
  Edit config
  Add skeleton format for DG to fit new target user
  Update skeletal user guide
  Update DG use case to match with updated UG
  Update UG
  Update UG based on PR Review
  Update UG to fix scope change
  Update UG command summary
  Update UG with fix naming convention
  Update DG use case with standardised terms used across UG
  Add use cases for developer guide v1.1
* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp:
  Update README
  Fix Checkstyle
  Add User Stories
  Fix checkstyle errors
  Create amount class
  Create date class
  Create description class
  Set up skeleton framework
  Update UG based on comments
  Update ReadMe
  Update command summary
  Revert "Merge branch 'user_guide_v1.1' into upstream_master"
  Update UG to add example
  - Basic code for FixedDay, Duration and TaskName - Addition of Enum Class - Update methods in ParserUtil for FixedDay, Duration and TaskName
* 'master' of https://github.com/AY2021S1-CS2103T-W13-3/tp:
  Replace person instance with client
  Fix testcases
  Edit UG for expenses
  Change formatting of UG
  Add documentation for expense feature in User Guide, and update individual portfolios to new theme
  Fix checkstyle errors
  Add attribute for ServiceCode
  Add tests for description
  Add tests for date class
  Add test for amount class
  Remove address field
The current DG's document structure could be more organised.

Let's add a table of contents and number each section accordingly.
Minor edits to NFR and Product Scope section to suit the new scope of GrAB3.
@khoongwk khoongwk added documentation Improvements or additions to documentation priority.High Must do labels Oct 3, 2020
@khoongwk khoongwk added this to the v1.2 milestone Oct 3, 2020
@khoongwk khoongwk self-assigned this Oct 3, 2020
@khoongwk khoongwk linked an issue Oct 3, 2020 that may be closed by this pull request
No newline was found at the end of the DG file. Fixed.
Copy link

@yanlynnnnn yanlynnnnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link

@RuiFengg RuiFengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make all fullstops for DG to standardize

docs/DeveloperGuide.md Show resolved Hide resolved
Adding of full stops to all bullet points.
Copy link

@RuiFengg RuiFengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RuiFengg RuiFengg merged commit 5a662e7 into AY2021S1-CS2103T-W13-3:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.High Must do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Developer Guide - Structure, Product Scope, NFR
3 participants