Add tests to Module and fix bugs of Lesson #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @simonteozw I think this PR is good to merge immediately but I just want you to take a look to see what I have done in this PR (mostly for the refactor of Lesson's messages, I wasn't aware that Lesson's messages structure were quite messy) |
simonteozw
reviewed
Nov 7, 2020
Comment on lines
279
to
283
| @Override | ||
| public boolean canAddModule() { | ||
| return getFilteredModuleList().size() < NUM_MODULE_LIMIT; | ||
| } | ||
|
|
There was a problem hiding this comment.
I feel that this function should also check if the module alr exists in trackit? Or maybe rename the function to hasEnoughSpace to make it clearer
Comment on lines
+18
to
+32
| // | ||
| // /** | ||
| // * Updates {@code model}'s filtered list to show only the module at the given {@code targetIndex} in the | ||
| // * {@code model}'s address book. | ||
| // */ | ||
| // public static void showModuleAtIndex(Model model, Index targetIndex) { | ||
| // assertTrue(targetIndex.getZeroBased() < model.getFilteredModuleList().size()); | ||
| // | ||
| // Module module = model.getFilteredModuleList().get(targetIndex.getZeroBased()); | ||
| // Predicate<Module> p = t -> t.getName().equals(module.getName()); | ||
| // model.updateFilteredModuleList(p); | ||
| // | ||
| // assertEquals(1, model.getFilteredModuleList().size()); | ||
| // } | ||
| } |
There was a problem hiding this comment.
Ah this I copied from TaskTestUtil but realised it's not usable yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.