Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show answer after certain commands #136

Conversation

jonfoocy
Copy link

@jonfoocy jonfoocy commented Nov 3, 2020

Sets visibility of answers to shown after add/edit/find commands.

Closes #127

@jonfoocy jonfoocy added the bug Something isn't working label Nov 3, 2020
@jonfoocy jonfoocy added this to the v1.4 milestone Nov 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #136 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
+ Coverage     69.28%   69.35%   +0.07%     
- Complexity      446      447       +1     
============================================
  Files            78       78              
  Lines          1377     1377              
  Branches        147      147              
============================================
+ Hits            954      955       +1     
+ Misses          377      376       -1     
  Partials         46       46              
Impacted Files Coverage Δ Complexity Δ
...va/seedu/medmoriser/logic/commands/AddCommand.java 85.71% <100.00%> (ø) 8.00 <0.00> (ø)
...a/seedu/medmoriser/logic/commands/EditCommand.java 92.98% <100.00%> (ø) 12.00 <0.00> (ø)
...a/seedu/medmoriser/logic/commands/FindCommand.java 90.47% <100.00%> (ø) 9.00 <0.00> (ø)
...seedu/medmoriser/logic/commands/CommandResult.java 90.90% <0.00%> (+4.54%) 13.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c03f9d...d638f5c. Read the comment docs.

Copy link

@joshruien joshruien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link

@yongmingyang yongmingyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@yongmingyang yongmingyang merged commit 3931203 into AY2021S1-CS2103T-W15-1:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Team Project
Awaiting triage
Development

Successfully merging this pull request may close these issues.

[PE-D] Editing answer after listing questions does not show answer edited in list
4 participants