PPP #168
Merged
PPP #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengjianling
requested changes
Nov 9, 2020
docs/team/chengjiyuqing.md
Outdated
|
|
||
| Given below are my contributions to the project. | ||
|
|
||
| * **New Feature**: Added the ability to undo/redo previous commands. |
There was a problem hiding this comment.
I think you forgot to edit this part since we don't have an undo/redo command
docs/team/chengjiyuqing.md
Outdated
| * Highlights: This enhancement affects existing commands and commands to be added in future. It required an in-depth analysis of design alternatives. The implementation too was challenging as it required changes to existing commands. | ||
| * Credits: *{mention here if you reused any code/ideas from elsewhere or if a third-party library is heavily used in the feature so that a reader can make a more accurate judgement of how much effort went into the feature}* | ||
|
|
||
| * **New Feature**: Added a history command that allows the user to navigate to previous commands using up/down keys. |
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
============================================
- Coverage 70.57% 70.39% -0.19%
- Complexity 481 488 +7
============================================
Files 79 79
Lines 1451 1459 +8
Branches 162 166 +4
============================================
+ Hits 1024 1027 +3
- Misses 377 380 +3
- Partials 50 52 +2
Continue to review full report at Codecov.
|
tengjianling
approved these changes
Nov 9, 2020
yongmingyang
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.