Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui #172

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Ui #172

merged 5 commits into from
Nov 9, 2020

Conversation

yongmingyang
Copy link

Change logo for medmoriser, updated quiz card UI

@yongmingyang yongmingyang added this to the v1.4 milestone Nov 9, 2020
@@ -292,7 +292,7 @@ While the changes to code may be minimal, the test data will have to be updated

<div markdown="span" class="alert alert-warning">

:exclamation: You must delete AddressBook’s storage file located at `/data/addressbook.json` before running it! Not doing so will cause AddressBook to default to an empty answer book!
:exclamation: You must delete AddressBook’s storage file located at `/data/medmoriser.json` before running it! Not doing so will cause AddressBook to default to an empty answer book!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'AddressBook' to 'Medmoriser'
'answer book' to 'question bank' or whatever term is appropriate?

Copy link

@jonfoocy jonfoocy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #172 (cd1b58a) into master (6a30122) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #172   +/-   ##
=========================================
  Coverage     70.57%   70.57%           
  Complexity      481      481           
=========================================
  Files            79       79           
  Lines          1451     1451           
  Branches        162      162           
=========================================
  Hits           1024     1024           
  Misses          377      377           
  Partials         50       50           
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/medmoriser/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/medmoriser/ui/UiManager.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a30122...cd1b58a. Read the comment docs.

Copy link

@tengjianling tengjianling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for helping with the GUI!

@yongmingyang yongmingyang merged commit 6103586 into AY2021S1-CS2103T-W15-1:master Nov 9, 2020
@yongmingyang yongmingyang self-assigned this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Team Project
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants