Quiz feature #62
Quiz feature #62
Conversation
* 'master' of https://github.com/joshruien/tp: Add testing for ListCommand update for CheckStyleTest Add testcases for Find command Add ability to hide answers change find format update TestCases files left out UserGuide update for find function javadoc update Find function find tag function find question and find answer Change URL of HelpCommand window Change ClearCommand success message
* branch-quiz: Implement quiz select random question
Includes Quiz command, Answer command and Exitquiz command
| @@ -73,4 +73,8 @@ shadowJar { | |||
| archiveName = 'medmoriser.jar' | |||
| } | |||
|
|
|||
| run { | |||
| enableAssertions = true | |||
There was a problem hiding this comment.
Thanks for this, totally missed out the requirement for tp
| * Creates an AnswerCommand | ||
| * @param answer The user's input answer. | ||
| */ | ||
| public AnswerCommand(String answer){ |
There was a problem hiding this comment.
may want to change the parameter to userAnswer for consistency
| */ | ||
| public class QuizCommand extends Command { | ||
|
|
||
| public static boolean isQuiz = false; |
There was a problem hiding this comment.
I'm not sure if the isQuiz state should be placed in the command. Do you think it would be possible to put it under a new class that controls the system's state? @jonfoocy what do you think about this?
There was a problem hiding this comment.
I'm not very sure about this either, I just added a getter and setter for isQuiz and made it a private static boolean.
There was a problem hiding this comment.
Good point actually I did the same thing for my implementation of the ListCommand. Maybe we can extract it and put it in the UiManager component?
Add getter and setter for isQuiz.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
============================================
- Coverage 72.12% 68.57% -3.56%
- Complexity 440 442 +2
============================================
Files 74 79 +5
Lines 1324 1394 +70
Branches 138 148 +10
============================================
+ Hits 955 956 +1
- Misses 335 396 +61
- Partials 34 42 +8
Continue to review full report at Codecov.
|
First iteration of the quiz feature for v1.3