Find command update #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonfoocy
requested changes
Oct 26, 2020
| @@ -18,7 +16,10 @@ public AnswerContainsKeywordsPredicate(List<String> keywords) { | |||
| @Override | |||
| public boolean test(QAndA qAndA) { | |||
| return keywords.stream() | |||
| .anyMatch(keyword -> StringUtil.containsWordIgnoreCase(qAndA.getAnswer().answer, keyword)); | |||
| .anyMatch(keyword -> { | |||
| System.out.println("current keyword is: " + keyword); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Q1: What is diabetes?
Tag: Chronic Diseases, Immunology
A1: Body unable to regulate blood sugar level
Q2: asdas
Tag: Nervous System, Immunology
A2: help
Q3: hehe
Tag: Immune System
A3: helpppppp
What needed fixing
find a/help
expected: return question 2 & 3
actual: returned all 3 questions
Why: Turns out, parser split a/help -> [a, help], and checked each answer to see if it contains "a" (resulted in Q1 being added).
Fixed: Parsed only the [help] into the predicates. Changes also made for find q/ and find t/.
close #76