Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG #225

Merged
Merged

Conversation

hogantan
Copy link

@hogantan hogantan commented Nov 6, 2020

Add (Diagrams):

  • ExamCommandClassDiagram
    ExamCommandClassDiagram

  • ExamStatsActivityDiagram
    ExamStatsActivityDiagram

  • ExamStatsSequenceDiagram
    ExamStatsSequenceDiagram

  • ToggleStudentCardSequenceDiagram
    ToggleStudentCardSequenceDiagram

Add (DG details):

  • Help command details
  • Toggle command details
  • Delete command details
  • Add Exam command details
  • Delete Exam command details
  • Exam Stats command details
  • User Stories
  • Use Cases

Add (Misc):

  • exam_stats_icon

Update:
UG structure
DG structure and details

Add:
ExamCommandClassDiagram
ExamStatsActivityDiagram
ExamStatsSequenceDiagram
ToggleStudentCardSequenceDiagram
exam_stats_icon

Update:
UG structure
DG structure and details
Copy link

@ong-yinggao98 ong-yinggao98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The activity diagrams might be too complex, perhaps we should split some up using the rake symbol. It seems that this guy here made a rake symbol that you can define in style.puml
https://forum.plantuml.net/195/is-there-any-support-for-subactivity-or-the-rake-symbol
After you do so I will have to do it too :(

Also, you could number your figures after the section
(e.g the third diagram in section 7.8.2 could be named fig 7.8.2.3)

@hogantan
Copy link
Author

hogantan commented Nov 6, 2020

The activity diagrams might be too complex, perhaps we should split some up using the rake symbol. It seems that this guy here made a rake symbol that you can define in style.puml

Do you mean the sequence diagrams or the activity diagrams?

@ong-yinggao98
Copy link

The activity diagrams might be too complex, perhaps we should split some up using the rake symbol. It seems that this guy here made a rake symbol that you can define in style.puml

Do you mean the sequence diagrams or the activity diagrams?

Oh now that I look at it it's not your activity diagrams but @VaishakAnand and mine >:(
Nvm

Copy link

@AlexCQY AlexCQY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ong-yinggao98
Copy link

ong-yinggao98 commented Nov 6, 2020

Could you number your figures before I merge?

@hogantan
Copy link
Author

hogantan commented Nov 6, 2020

Could you number your figures before I merge?

Do you think the numbering convention of following the table contents could get quite messy? (e.g. Figure 6.8.1.1a )

Should we follow the traditional style instead? (Figure 1, Figure 2, etc.)

@ong-yinggao98
Copy link

Should we follow the traditional style instead? (Figure 1, Figure 2, etc.)

Hmmm I guess aight

@ong-yinggao98 ong-yinggao98 merged commit 5ce9b20 into AY2021S1-CS2103T-W15-2:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants