Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #45: Implements (simplified) Student Class #50

Merged
merged 6 commits into from Oct 6, 2020
Merged

Resolves #45: Implements (simplified) Student Class #50

merged 6 commits into from Oct 6, 2020

Conversation

ong-yinggao98
Copy link

Changes:

  • Year now only accepts numerical values

To-Do:

  • Document changes better
  • More test cases
  • Implement Admin and other classes

@ong-yinggao98
Copy link
Author

After we merge this we should merge v1.2 branch into master already

@ong-yinggao98 ong-yinggao98 changed the title Implements (simplified) Student Class; resolves #45 Implements (simplified) Student Class; Fixes #45 Oct 6, 2020
@ong-yinggao98 ong-yinggao98 changed the title Implements (simplified) Student Class; Fixes #45 Resolves #45: Implements (simplified) Student Class Oct 6, 2020
hogantan
hogantan approved these changes Oct 6, 2020
View reviewed changes
Copy link

@hogantan hogantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlexCQY
AlexCQY approved these changes Oct 6, 2020
View reviewed changes
Copy link

@AlexCQY AlexCQY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexCQY AlexCQY merged commit e6533c6 into AY2021S1-CS2103T-W15-2:v1.2 Oct 6, 2020
@ong-yinggao98 ong-yinggao98 mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexCQY AlexCQY AlexCQY approved these changes

@hogantan hogantan hogantan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ong-yinggao98 @AlexCQY @hogantan