Fixes #47 #53
Merged
Fixes #47 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a few unnoticed Tag mentions
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
Coverage ? 66.42%
Complexity ? 370
=========================================
Files ? 73
Lines ? 1230
Branches ? 120
=========================================
Hits ? 817
Misses ? 373
Partials ? 40
Continue to review full report at Codecov.
|
ong-yinggao98
requested changes
Oct 7, 2020
Fixed wrong syntax for Year
Changed more tag references to AdditionalDetail refs
ong-yinggao98
approved these changes
Oct 7, 2020
csiongn
reviewed
Oct 7, 2020
| @@ -9,14 +9,22 @@ | |||
| import seedu.address.model.student.Year; | |||
| import seedu.address.model.student.admin.Admin; | |||
|
|
|||
|
|
|||
| /** | |||
| * Contains utility methods for populating {@code AddressBook} with sample data. | |||
There was a problem hiding this comment.
Should we remove the traces of address book?
There was a problem hiding this comment.
Good catch! I'll remove it in my next PR.
csiongn
reviewed
Oct 7, 2020
| @@ -22,6 +22,7 @@ | |||
| import seedu.address.model.student.Year; | |||
| import seedu.address.model.student.admin.Admin; | |||
|
|
|||
|
|
|||
| /** | |||
| * Edits the details of an existing person in the address book. | |||
There was a problem hiding this comment.
here also but i think rmb to change later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated AdditionalDetail, ClassVenue and ClassTime, and AdditionalDetail tests (that were initially from Tag).
Replaced all Tag occurences with AdditionalDetail