Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRIC bug #144

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Fix NRIC bug #144

merged 1 commit into from
Oct 25, 2020

Conversation

Cedo8
Copy link

@Cedo8 Cedo8 commented Oct 25, 2020

Update Add, Delete and Edit functionality
Update test cases relating to NRIC

Update Add, Delete and Edit functionality
Update test cases relating to NRIC
@Cedo8 Cedo8 added the bug severity.High A flaw that affects most users and causes major problems for users label Oct 25, 2020
@Cedo8 Cedo8 added this to the v1.3 milestone Oct 25, 2020
@Cedo8 Cedo8 self-assigned this Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #144 into master will increase coverage by 0.31%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
+ Coverage     57.23%   57.54%   +0.31%     
- Complexity      448      456       +8     
============================================
  Files            91       91              
  Lines          1763     1776      +13     
  Branches        197      201       +4     
============================================
+ Hits           1009     1022      +13     
  Misses          700      700              
  Partials         54       54              
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 95.29% <60.00%> (-2.30%) 13.00 <0.00> (+1.00) ⬇️
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø) 9.00 <0.00> (+1.00)
...va/seedu/address/logic/commands/DeleteCommand.java 93.75% <100.00%> (+0.20%) 15.00 <1.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 93.75% <100.00%> (ø) 13.00 <0.00> (ø)
src/main/java/seedu/address/model/HospifyBook.java 87.87% <100.00%> (+2.69%) 16.00 <3.00> (+3.00)
...rc/main/java/seedu/address/model/ModelManager.java 96.15% <100.00%> (+0.15%) 25.00 <1.00> (+1.00)
...main/java/seedu/address/model/patient/Patient.java 83.07% <0.00%> (+1.53%) 26.00% <0.00%> (+1.00%)
...seedu/address/model/patient/UniquePatientList.java 79.31% <0.00%> (+1.72%) 28.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76cbed...ed6e5bf. Read the comment docs.

@Cedo8 Cedo8 merged commit 07a5832 into AY2021S1-CS2103T-W15-3:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug severity.High A flaw that affects most users and causes major problems for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants