Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-D review bug fixes #226

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Conversation

Cedo8
Copy link

@Cedo8 Cedo8 commented Nov 1, 2020

Fix success message bugs
Fix edit bug
Fix bug where adding patients with same medical record url works
Update email format
Fix and update test cases

Fix edit bug
Fix bug where adding patients with same medical record url works
Update email format
Fix and update test cases
@Cedo8 Cedo8 added type.Bug A bug priority.High Must do bug severity.High A flaw that affects most users and causes major problems for users labels Nov 1, 2020
@Cedo8 Cedo8 added this to the v1.4 milestone Nov 1, 2020
@Cedo8 Cedo8 self-assigned this Nov 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #226 into master will decrease coverage by 0.13%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
- Coverage     58.06%   57.93%   -0.14%     
- Complexity      479      484       +5     
============================================
  Files            91       91              
  Lines          1860     1878      +18     
  Branches        204      211       +7     
============================================
+ Hits           1080     1088       +8     
- Misses          723      729       +6     
- Partials         57       61       +4     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...c/main/java/seedu/address/model/patient/Email.java 80.00% <ø> (ø) 6.00 <0.00> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 87.50% <33.33%> (-12.50%) 9.00 <0.00> (ø)
src/main/java/seedu/address/model/HospifyBook.java 79.48% <33.33%> (-14.46%) 17.00 <1.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 93.47% <55.55%> (-1.82%) 16.00 <2.00> (+3.00) ⬇️
...ava/seedu/address/logic/commands/CountCommand.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <100.00%> (ø) 27.00 <1.00> (+1.00)
...ava/seedu/address/model/patient/MedicalRecord.java 80.00% <100.00%> (ø) 6.00 <1.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0ab23...e28cc85. Read the comment docs.

@Cedo8 Cedo8 merged commit fc04fda into AY2021S1-CS2103T-W15-3:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug severity.High A flaw that affects most users and causes major problems for users priority.High Must do type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants