Add enhancements to UG and DG #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=========================================
Coverage 74.27% 74.27%
Complexity 528 528
=========================================
Files 83 83
Lines 1555 1555
Branches 154 154
=========================================
Hits 1155 1155
Misses 340 340
Partials 60 60
Continue to review full report at Codecov.
|
lamlaaaam
reviewed
Oct 26, 2020
docs/DeveloperGuide.md
Outdated
| @@ -91,7 +91,7 @@ The `UI` component, | |||
|
|
|||
| 1. `Logic` uses the `AddressBookParser` class to parse the user command. | |||
| 1. This results in a `Command` object which is executed by the `LogicManager`. | |||
| 1. The command execution can affect the `Model` (e.g. adding a person). | |||
| 1. The command execution can affect the `Model` (e.g. adding a animal). | |||
m0nggh
reviewed
Oct 26, 2020
docs/DeveloperGuide.md
Outdated
|
|
||
| 1. Other incorrect delete commands to try: `delete`, `delete x`, `...` (where x is larger than the list size)<br> | ||
| 1. Other incorrect delete commands to try: `delete`, `delete x`, `...` (where x is smaller than the requisite size)<br> |
There was a problem hiding this comment.
Think this one is for the delete index?
There was a problem hiding this comment.
Updated it to 'where x is smaller than all 3 digit numbers' since these are examples of incorrect delete commands
docs/DeveloperGuide.md
Outdated
Comment on lines
742
to
754
| 1. Deleting an animal while not all animals are being shown | ||
|
|
||
| 1. Prerequisites: Use `find 455` command to list animals that contain 455 in any of their fields. | ||
| 2 animals are listed: an anaconda named 455 and a lion named Simba with an ID of 455. | ||
|
|
||
| 1. Test case: `delete 455`<br> | ||
| Expected: Simba with an ID of 455 is deleted from the list. Details of the deleted animal shown in the status message. Timestamp in the status bar is updated. | ||
|
|
||
| 1. Test case: `delete 123`<br> | ||
| Expected: No animal is deleted. Error details shown in the status message. Status bar remains the same. | ||
|
|
||
| 1. Other incorrect delete commands to try: `delete`, `delete x`, `...` (where x is smaller than the requisite size)<br> | ||
| Expected: Similar to previous. |
There was a problem hiding this comment.
May have to modify this since delete should work without finding anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.