Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting of animals in lowercase #300

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

m0nggh
Copy link

@m0nggh m0nggh commented Nov 1, 2020

Resolves #299.

@m0nggh m0nggh added this to the v1.4 milestone Nov 1, 2020
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #300 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
+ Coverage     74.87%   74.92%   +0.04%     
  Complexity      546      546              
============================================
  Files            83       83              
  Lines          1584     1587       +3     
  Branches        160      160              
============================================
+ Hits           1186     1189       +3     
  Misses          340      340              
  Partials         58       58              
Impacted Files Coverage Δ Complexity Δ
...java/seedu/zookeep/logic/commands/SortCommand.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...a/seedu/zookeep/model/animal/AnimalComparator.java 97.05% <100.00%> (+0.18%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7cc6b...abfbcb8. Read the comment docs.

@lamlaaaam lamlaaaam merged commit 16131d1 into AY2021S1-CS2103T-W15-4:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort names regardless of lowercase or uppercase
2 participants