Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change delete command to use ID instead of index #65

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

koonweee
Copy link

@koonweee koonweee commented Oct 5, 2020

  • Update delete command to use ID instead of index
  • Update input validation for a valid ID (> 3 digits) instead of index
  • Removed irrelevant test (Command exception became parse exception)

Resolve #55

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #65 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     72.31%   72.42%   +0.11%     
- Complexity      400      402       +2     
============================================
  Files            70       70              
  Lines          1228     1233       +5     
  Branches        124      126       +2     
============================================
+ Hits            888      893       +5     
  Misses          308      308              
  Partials         32       32              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <100.00%> (ø) 9.00 <1.00> (+2.00)
...java/seedu/address/logic/commands/EditCommand.java 97.01% <100.00%> (ø) 12.00 <0.00> (ø)
...eedu/address/logic/parser/DeleteCommandParser.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8792a0a...5f7044f. Read the comment docs.

@lamlaaaam lamlaaaam added this to the v1.2 milestone Oct 5, 2020
@m0nggh m0nggh merged commit 3b243dc into AY2021S1-CS2103T-W15-4:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify delete command to take in an id instead of index
3 participants