Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Email field #68

Merged

Conversation

m0nggh
Copy link

@m0nggh m0nggh commented Oct 5, 2020

Removed the email field for animals without new functionalities added yet. Made minor changes to id and species references. Closes #52

@m0nggh m0nggh added this to the v1.2 milestone Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #68 into master will decrease coverage by 0.62%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
- Coverage     72.42%   71.79%   -0.63%     
+ Complexity      402      388      -14     
============================================
  Files            70       69       -1     
  Lines          1233     1195      -38     
  Branches        126      119       -7     
============================================
- Hits            893      858      -35     
+ Misses          308      306       -2     
+ Partials         32       31       -1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/seedu/address/logic/parser/CliSyntax.java 80.00% <ø> (-3.34%) 1.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.77% <ø> (-0.45%) 12.00 <0.00> (-2.00)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/AnimalCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/model/animal/Animal.java 97.22% <75.00%> (-0.34%) 18.00 <0.00> (-3.00)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 96.72% <100.00%> (-0.30%) 12.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 91.66% <100.00%> (-0.65%) 10.00 <0.00> (-1.00)
.../java/seedu/address/storage/JsonAdaptedAnimal.java 100.00% <100.00%> (ø) 9.00 <0.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9508ad...66a479f. Read the comment docs.

@aizatazhar aizatazhar changed the title Removed the email field for animals Remove Email field Oct 6, 2020
@aizatazhar aizatazhar merged commit 2651031 into AY2021S1-CS2103T-W15-4:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete email field
2 participants