Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4 minor adjustment according to feedback from PE-Dry run #171

Merged
merged 7 commits into from
Nov 3, 2020

Conversation

lincolnkoh99
Copy link

No description provided.

@lincolnkoh99 lincolnkoh99 self-assigned this Nov 3, 2020
@lincolnkoh99 lincolnkoh99 added documentation Improvements or additions to documentation priority.High labels Nov 3, 2020
@lincolnkoh99 lincolnkoh99 added this to the v1.4 milestone Nov 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #171 into master will increase coverage by 0.15%.
The diff coverage is 44.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #171      +/-   ##
============================================
+ Coverage     56.75%   56.90%   +0.15%     
  Complexity      680      680              
============================================
  Files           122      122              
  Lines          2747     2745       -2     
  Branches        316      316              
============================================
+ Hits           1559     1562       +3     
+ Misses         1063     1056       -7     
- Partials        125      127       +2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/commons/util/StringUtil.java 94.73% <ø> (+19.73%) 7.00 <0.00> (ø)
...eedu/address/logic/commands/AddContactCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...eedu/address/logic/commands/AddMeetingCommand.java 80.00% <0.00%> (ø) 9.00 <0.00> (ø)
.../address/logic/commands/AddParticipantCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...du/address/logic/commands/ClearContactCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...du/address/logic/commands/ClearMeetingCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...u/address/logic/commands/DeleteContactCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...u/address/logic/commands/DeleteMeetingCommand.java 85.00% <ø> (ø) 9.00 <0.00> (ø)
...dress/logic/commands/DeleteParticipantCommand.java 75.00% <ø> (ø) 7.00 <0.00> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdac57...87d3193. Read the comment docs.

@AdithyaNarayan
Copy link

LGTM! Good job on fixing bugs mentioned in PE Dry Run. I see that you have fixed bugs that you have discovered yourself too! Thanks for taking the initiative

@AdithyaNarayan AdithyaNarayan merged commit 4eadcd0 into AY2021S1-CS2103T-W16-1:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment