Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch v1.3 #106

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Conversation

zhizhizhizhizhi
Copy link

No description provided.

@zhizhizhizhizhi zhizhizhizhizhi added this to the v1.3 milestone Oct 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #106 into master will increase coverage by 0.35%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
+ Coverage     70.10%   70.45%   +0.35%     
- Complexity      435      449      +14     
============================================
  Files            75       76       +1     
  Lines          1368     1408      +40     
  Branches        132      135       +3     
============================================
+ Hits            959      992      +33     
- Misses          361      362       +1     
- Partials         48       54       +6     
Impacted Files Coverage Δ Complexity Δ
.../forgetfulnus/logic/parser/GlossaryBookParser.java 69.56% <0.00%> (-3.17%) 12.00 <0.00> (ø)
src/main/java/seedu/forgetfulnus/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...seedu/forgetfulnus/logic/commands/FindCommand.java 91.66% <50.00%> (ø) 8.00 <1.00> (ø)
...seedu/forgetfulnus/logic/commands/ListCommand.java 85.71% <50.00%> (-1.79%) 4.00 <1.00> (ø)
...du/forgetfulnus/model/flashcard/EnglishPhrase.java 71.42% <66.66%> (-8.58%) 8.00 <1.00> (+2.00) ⬇️
...du/forgetfulnus/logic/commands/EndQuizCommand.java 76.19% <75.00%> (+2.27%) 6.00 <1.00> (+1.00)
.../seedu/forgetfulnus/logic/commands/TryCommand.java 80.00% <80.00%> (ø) 6.00 <6.00> (?)
...edu/forgetfulnus/logic/commands/CommandResult.java 88.88% <100.00%> (+0.65%) 11.00 <1.00> (+1.00)
...seedu/forgetfulnus/logic/commands/NextCommand.java 82.60% <100.00%> (-3.76%) 5.00 <0.00> (-1.00)
...seedu/forgetfulnus/logic/commands/QuizCommand.java 94.11% <100.00%> (+0.36%) 5.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef91c3...af5d77e. Read the comment docs.

Copy link

@kswk kswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kswk kswk linked an issue Oct 19, 2020 that may be closed by this pull request
@kswk kswk merged commit c252450 into AY2021S1-CS2103T-W16-2:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoring feature
3 participants