Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ug #135

Merged
merged 6 commits into from
Oct 25, 2020
Merged

Update ug #135

merged 6 commits into from
Oct 25, 2020

Conversation

YangJiyu98
Copy link

No description provided.

kswk
kswk requested changes Oct 25, 2020
View reviewed changes
Copy link

@kswk kswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under SampleDataUtil.java and TypicalFlashCards.java, days of the week are masculine, hence should not be set to neutral, words like morning and midday are also masculine.

tjwjoe
tjwjoe approved these changes Oct 25, 2020
View reviewed changes
Copy link

@tjwjoe tjwjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kswk
kswk approved these changes Oct 25, 2020
View reviewed changes
Copy link

@kswk kswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kswk kswk merged commit aa76b86 into AY2021S1-CS2103T-W16-2:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswk kswk kswk approved these changes

@tjwjoe tjwjoe tjwjoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YangJiyu98 @kswk @tjwjoe