Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch v1.4 #230

Merged
merged 4 commits into from
Nov 7, 2020
Merged

Conversation

zhizhizhizhizhi
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #230 (afecde6) into master (eab9036) will decrease coverage by 0.26%.
The diff coverage is 56.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
- Coverage     68.83%   68.56%   -0.27%     
- Complexity      558      560       +2     
============================================
  Files            92       92              
  Lines          1893     1912      +19     
  Branches        208      209       +1     
============================================
+ Hits           1303     1311       +8     
- Misses          515      526      +11     
  Partials         75       75              
Impacted Files Coverage Δ Complexity Δ
...java/seedu/forgetfulnus/ui/FlashCardListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/forgetfulnus/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/seedu/forgetfulnus/logic/LogicManager.java 72.72% <100.00%> (ø) 3.00 <0.00> (ø)
...edu/forgetfulnus/logic/commands/CommandResult.java 90.90% <100.00%> (+2.02%) 13.00 <3.00> (+2.00)
...seedu/forgetfulnus/logic/commands/NextCommand.java 83.33% <100.00%> (+1.51%) 5.00 <0.00> (ø)
...seedu/forgetfulnus/logic/commands/QuizCommand.java 84.21% <100.00%> (ø) 5.00 <0.00> (ø)
...forgetfulnus/logic/commands/RandomQuizCommand.java 83.78% <100.00%> (ø) 7.00 <0.00> (ø)
.../seedu/forgetfulnus/logic/commands/TryCommand.java 82.60% <100.00%> (+1.65%) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab9036...afecde6. Read the comment docs.

@zhizhizhizhizhi zhizhizhizhizhi marked this pull request as draft November 6, 2020 20:36
@zhizhizhizhizhi zhizhizhizhizhi marked this pull request as ready for review November 6, 2020 20:37
Copy link

@kswk kswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kswk kswk merged commit 1130f11 into AY2021S1-CS2103T-W16-2:master Nov 7, 2020
@zhizhizhizhizhi zhizhizhizhizhi added this to the v1.4 milestone Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants