Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance add and edit command #233

Merged

Conversation

YangJiyu98
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #233 (43c8bcf) into master (3db5f46) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
+ Coverage     68.83%   68.98%   +0.15%     
- Complexity      558      575      +17     
============================================
  Files            92       92              
  Lines          1893     1938      +45     
  Branches        208      212       +4     
============================================
+ Hits           1303     1337      +34     
- Misses          515      526      +11     
  Partials         75       75              
Impacted Files Coverage Δ Complexity Δ
...java/seedu/forgetfulnus/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...du/forgetfulnus/logic/parser/AddCommandParser.java 90.24% <100.00%> (+4.03%) 16.00 <4.00> (+8.00)
...du/forgetfulnus/logic/parser/ArgumentMultimap.java 100.00% <100.00%> (ø) 11.00 <4.00> (+4.00)
...u/forgetfulnus/logic/parser/EditCommandParser.java 95.12% <100.00%> (+1.18%) 14.00 <3.00> (+3.00)
...rc/main/java/seedu/forgetfulnus/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...java/seedu/forgetfulnus/ui/FlashCardListPanel.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../seedu/forgetfulnus/logic/commands/AddCommand.java 95.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
...seedu/forgetfulnus/logic/commands/QuizCommand.java 84.21% <0.00%> (ø) 5.00% <0.00%> (ø%)
...forgetfulnus/logic/commands/RandomQuizCommand.java 83.78% <0.00%> (ø) 7.00% <0.00%> (ø%)
...seedu/forgetfulnus/logic/commands/NextCommand.java 83.33% <0.00%> (+1.51%) 5.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db5f46...43c8bcf. Read the comment docs.

@YangJiyu98 YangJiyu98 linked an issue Nov 7, 2020 that may be closed by this pull request
Copy link

@tjwjoe tjwjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjwjoe tjwjoe merged commit 3223f8b into AY2021S1-CS2103T-W16-2:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Adding multiple gender should result in error message
3 participants