Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reset Scores feature, make GUI bigger, and update UG #236

Merged
merged 7 commits into from
Nov 8, 2020

Conversation

rayasamhr
Copy link

Fixes #193, #175, #200, and #208.

@rayasamhr rayasamhr added this to the v1.4 milestone Nov 8, 2020
@rayasamhr rayasamhr self-assigned this Nov 8, 2020
@@ -35,6 +35,7 @@ public CommandResult execute(Model model) {
model.setRandomQuizMode(false);
}
model.saveScore();
System.out.println(model.getQuizTotalQuestions());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you added this for debugging? Should probably get rid of it if so

@@ -122,6 +123,13 @@ public Command parseCommand(String userInput) throws ParseException, ParseZeroEx
}
throw new ParseException(MESSAGE_UNKNOWN_COMMAND);

case ResetScoreCommand.COMMAND_WORD:
System.out.println(arguments);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you added this for debugging? Should probably get rid of it if so

Copy link

@tjwjoe tjwjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjwjoe tjwjoe merged commit 79c381f into AY2021S1-CS2103T-W16-2:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Inconsistency with scores feature
2 participants